Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the CONTRIBUTING.md file to include #expensify-bugs guidance #12373

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Updating the CONTRIBUTING.md file to include #expensify-bugs guidance #12373

merged 2 commits into from
Nov 10, 2022
+22 −16

Conversation

michaelhaxhiu
Copy link
Contributor

@michaelhaxhiu michaelhaxhiu commented Nov 2, 2022 •
edited
Loading

cc @JmillsExpensify @mallenexpensify

Details

  • Updated all guidance to embody the new world of Bug vs New Feature
  • Re-worked the Ask Questions header to be Slack Channels
  • Added guidance on #expensify-bug channel throughout
  • Cleaned up verbiage in some areas as I went through this, mainly for the sake of clarity

Fixed Issues

https://github.com/Expensify/Expensify/issues/240113

@michaelhaxhiu
Update CONTRIBUTING.md
2f46a1d 
- Updated all guidance to embody the new world of Bug vs New Feature
- Added guidance on #expensify-bug channel
- Cleaned up various verbiage as I went for the sake of clarity
@michaelhaxhiu michaelhaxhiu requested a review from a team as a code owner November 2, 2022 15:40
@michaelhaxhiu
Copy link
Contributor Author

Hold on this please - need to get other changes ready before this is deployed to the production file.

@melvin-bot melvin-bot bot requested review from Julesssss and removed request for a team November 2, 2022 15:41
@Julesssss
Copy link
Contributor

Sure, just ping me when it's ready for review 👍

@dylanexpensify dylanexpensify self-requested a review November 2, 2022 16:28
dylanexpensify
dylanexpensify reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@dylanexpensify dylanexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 28: For discussing the difference of use-case behind each room, it isn't clear if discussing issues around bugs would be in the bug channel or the open source channel since it says it's only for reporting.

Line 49: A job may be fixing a bug or working on a new feature. (take it or leave it, I just think that sounds better)

Line 55: is the identifying bug payment only if they propose a solution? I thought not. Also, "If the bug or feature is fixed by a PR that is not associated with your proposal, the contributor is not eligible for compensation unless they can find the PR that fixed it and prove their porposal preceded the one associated with the PR." to "If the bug or feature is fixed by a PR that is not associated with your proposal, then you will not be eligible for the associated compensation unless you can find the PR that fixed it and that yours preceded that one."

@michaelhaxhiu
Update CONTRIBUTING.md
ef9f5bf 
Added changes from Dylan's suggestions
@michaelhaxhiu
Copy link
Contributor Author

michaelhaxhiu commented Nov 2, 2022 •
edited
Loading

@dylanexpensify

Line 28: For discussing the difference of use-case behind each room, it isn't clear if discussing issues around bugs would be in the bug channel or the open source channel since it says it's only for reporting.

Fixed!

Line 49: A job may be fixing a bug or working on a new feature. (take it or leave it, I just think that sounds better)

Updated!

Line 55: is the identifying bug payment only if they propose a solution? I thought not. Also, "If the bug or feature is fixed by a PR that is not associated with your proposal, the contributor is not eligible for compensation unless they can find the PR that fixed it and prove their porposal preceded the one associated with the PR." to "If the bug or feature is fixed by a PR that is not associated with your proposal, then you will not be eligible for the associated compensation unless you can find the PR that fixed it and that yours preceded that one."

Line 55: is the identifying bug payment only if they propose a solution? -- what do you mean @dylanexpensify? Can you expand this a little more?

If the bug or feature is fixed by a PR that is not associated with your proposal, then you will not be eligible for the associated compensation unless you can find the PR that fixed it and that yours preceded that one.

Added but made a tiny tweak.

@Beamanator Beamanator changed the title [Hold] Hax - updating the CONTRIBUTING.md file to include #expensify-bugs guidace [Hold] Hax - updating the CONTRIBUTING.md file to include #expensify-bugs guidance Nov 3, 2022
@dylanexpensify
Copy link
Contributor

Ah yeah, so line 55 basically makes it seem like you have to report the bug and propose a solution to get the reporting bonus, but to my knowledge I thought they could just report the bug and get the bonus and not need to provide a potential solution!

@michaelhaxhiu
Copy link
Contributor Author

@Julesssss this should be good to finalize today, once https://github.com/Expensify/Expensify/issues/241611 is finalized.

If this is complete after you are offline, should I just remove you and re-assign pullerbear?

@michaelhaxhiu michaelhaxhiu requested review from dylanexpensify and a team and removed request for Julesssss and dylanexpensify November 8, 2022 22:36
@melvin-bot melvin-bot bot requested review from Julesssss and removed request for a team November 8, 2022 22:37
@michaelhaxhiu
Copy link
Contributor Author

Thanks for no scoping this PR @nathanmetcalf 🎯.

@Julesssss
Copy link
Contributor

@michaelhaxhiu is this still on hold?

@michaelhaxhiu
Copy link
Contributor Author

Yes still on hold while Slack support gives us hell 🔥

@michaelhaxhiu
Copy link
Contributor Author

Let's not deploy it quite yet. Sorry this is... ad tedium

@michaelhaxhiu michaelhaxhiu changed the title [Hold] Hax - updating the CONTRIBUTING.md file to include #expensify-bugs guidance Hax - updating the CONTRIBUTING.md file to include #expensify-bugs guidance Nov 10, 2022
@michaelhaxhiu michaelhaxhiu changed the title Hax - updating the CONTRIBUTING.md file to include #expensify-bugs guidance Updating the CONTRIBUTING.md file to include #expensify-bugs guidance Nov 10, 2022
@michaelhaxhiu
Copy link
Contributor Author

Let's do this thing now, just got unblocked and ready to proceed.

@michaelhaxhiu michaelhaxhiu merged commit a76173a into main Nov 10, 2022
@michaelhaxhiu michaelhaxhiu deleted the AddingNewSlackChannel branch November 10, 2022 19:28
@melvin-bot melvin-bot bot added the Emergency label Nov 10, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 10, 2022

@michaelhaxhiu looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@michaelhaxhiu
Copy link
Contributor Author

It's live

@OSBotify OSBotify mentioned this pull request Nov 11, 2022
Closed
27 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @michaelhaxhiu in version: 1.2.27-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.2.27-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.2.27-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanexpensify dylanexpensify dylanexpensify left review comments

@Julesssss Julesssss Julesssss approved these changes

@nathanmetcalf nathanmetcalf nathanmetcalf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelhaxhiu @Julesssss @dylanexpensify @OSBotify @nathanmetcalf